chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, don't include useless switches Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/common/chrome_switches.h » ('j') | components/metrics/metrics_service_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 6aa71c8233d83c39f11217f8f3cbf356cb27f17d..f4588bb113ca05bd049f7f0fe41e5f854754641d 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -180,7 +180,17 @@ void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {

void ChromeMetricsServiceClient::SetMetricsClientId(

const std::string& client_id) {

+#if defined(OS_MACOSX)

+ crash_keys::SetMetricsClientIdFromGUID(client_id);

+#else

crash_keys::SetCrashClientIdFromGUID(client_id);

+#endif

+void ChromeMetricsServiceClient::RecordingDisabled() {

+#if defined(OS_MACOSX)

+ crash_keys::ClearMetricsClientId();

+#endif

Ilya Sherman 2015/03/24 00:22:23 Optional: IMO, it would be nicer if the crash_keys

}

bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/common/chrome_switches.h » ('j') | components/metrics/metrics_service_client.h » ('J')