Set a "metrics_client_id" crash key instead of "guid" on Mac OS X

chrome/browser/metrics/chrome_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 162 matching lines @@
   AndroidMetricsProvider::RegisterPrefs(registry);
 #endif  // defined(OS_ANDROID)
 
 #if defined(ENABLE_PLUGINS)
   PluginMetricsProvider::RegisterPrefs(registry);
 #endif  // defined(ENABLE_PLUGINS)
 }
 
 void ChromeMetricsServiceClient::SetMetricsClientId(
     const std::string& client_id) {
+#if defined(OS_MACOSX)
+  crash_keys::SetMetricsClientIdFromGUID(client_id);
+#else
   crash_keys::SetCrashClientIdFromGUID(client_id);
+#endif
+}
+
+void ChromeMetricsServiceClient::RecordingDisabled() {
+#if defined(OS_MACOSX)
+  crash_keys::ClearMetricsClientId();
+#endif

[Ilya Sherman, 2015/03/24 00:22:23]

Optional: IMO, it would be nicer if the crash_keys API was platform-neutral, and
the implementation details handled all the OS-checks.

 }
 
 bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {
   return chrome::IsOffTheRecordSessionActive();
 }
 
 int32 ChromeMetricsServiceClient::GetProduct() {
   return metrics::ChromeUserMetricsExtension::CHROME;
 }
 
@@ skipping 401 matching lines @@
   // Capture the histogram samples.
   if (dumps_with_crash != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithCrash", dumps_with_crash);
   if (dumps_with_no_crash != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithNoCrash", dumps_with_no_crash);
   int total_dumps = dumps_with_crash + dumps_with_no_crash;
   if (total_dumps != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserCrashDumpAttempts", total_dumps);
 }
 #endif  // defined(OS_WIN)