Fix measurement of DeviceMotion and DeviceOrientation on secure origins.

Fix measurement of DeviceMotion and DeviceOrientation on secure origins.

The current code actually logs all eventTypes in didAddEventListener, while we
only need to record the data for the relevant eventTypes, i.e. devicemotion
or deviceorientation.

BUG=447525
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191842

[timvolodine, 2015-03-12 17:15:58]

timvolodine@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-03-12 21:25:12]

LGTM, assuming that the side-effects of the early return are intentional. Thanks
for taking a look at this!

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
File Source/modules/device_orientation/DeviceMotionController.cpp (right):

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
Source/modules/device_orientation/DeviceMotionController.cpp:62:
DeviceSingleWindowEventController::didAddEventListener(window, eventType);
Returning early changes the behavior of this delegation as well. Is that
intentional?

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
File Source/modules/device_orientation/DeviceOrientationController.cpp (right):

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
Source/modules/device_orientation/DeviceOrientationController.cpp:69:
DeviceSingleWindowEventController::didAddEventListener(window, eventType);
Ditto.

[timvolodine, 2015-03-13 11:40:55]

thanks, yeah I came across this unintentionally while trying to debug something
else..

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
File Source/modules/device_orientation/DeviceMotionController.cpp (right):

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
Source/modules/device_orientation/DeviceMotionController.cpp:62:
DeviceSingleWindowEventController::didAddEventListener(window, eventType);
On 2015/03/12 21:25:12, Mike West wrote:
> Returning early changes the behavior of this delegation as well. Is that
> intentional?

that's no problem, actually this method has an early return as well, it's just
the logging that is impacted.

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
File Source/modules/device_orientation/DeviceOrientationController.cpp (right):

https://codereview.chromium.org/1000173002/diff/1/Source/modules/device_orien...
Source/modules/device_orientation/DeviceOrientationController.cpp:69:
DeviceSingleWindowEventController::didAddEventListener(window, eventType);
On 2015/03/12 21:25:12, Mike West wrote:
> Ditto.

Done.

[timvolodine, 2015-03-13 12:12:32]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-03-13 12:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000173002/1

[commit-bot: I haz the power, 2015-03-13 13:36:32]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191842