Source/modules/device_orientation/DeviceMotionController.cpp - Issue 1000173002: Fix measurement of DeviceMotion and DeviceOrientation on secure origins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceMotionController.cpp

Issue 1000173002: Fix measurement of DeviceMotion and DeviceOrientation on secure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Source/modules/device_orientation/DeviceOrientationController.cpp » ('j') | Source/modules/device_orientation/DeviceOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceMotionController.cpp

diff --git a/Source/modules/device_orientation/DeviceMotionController.cpp b/Source/modules/device_orientation/DeviceMotionController.cpp

index 22cdef0a71b8bde87b6e10a35aa9d290b0f86dd3..adb45324a4dc2e939c7c0bd77bef3d0247749600 100644

--- a/Source/modules/device_orientation/DeviceMotionController.cpp

+++ b/Source/modules/device_orientation/DeviceMotionController.cpp

@@ -45,6 +45,9 @@ DeviceMotionController& DeviceMotionController::from(Document& document)

void DeviceMotionController::didAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)

{

+ if (eventType != eventTypeName())

+ return;

if (document().frame()) {

String errorMessage;

if (document().securityOrigin()->canAccessFeatureRequiringSecureOrigin(errorMessage)) {