Issue 972933002: add arguments to constructor completions

Issue 972933002: add arguments to constructor completions (Closed)

Created:
5 years, 9 months ago by danrubel

Modified:
5 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

add arguments to constructor completions BUG=dartbug.com/22158 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44174

Patch Set 3 : fix tests #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+497 lines, -124 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart	View		4 chunks	+27 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/imported_computer.dart	View		8 chunks	+61 lines, -28 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/local_computer.dart	View		11 chunks	+251 lines, -71 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/optype.dart	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/completion_test.dart	View	1 2	4 chunks	+4 lines, -4 lines	2 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View		6 chunks	+35 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/imported_computer_test.dart	View		2 chunks	+52 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/local_computer_test.dart	View		2 chunks	+49 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/optype_test.dart	View		4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

https://codereview.chromium.org/972933002/diff/40001/pkg/analysis_server/test/completion_test.dart File pkg/analysis_server/test/completion_test.dart (right): https://codereview.chromium.org/972933002/diff/40001/pkg/analysis_server/test/completion_test.dart#newcode256 pkg/analysis_server/test/completion_test.dart:256: ], failingTests: '123'); Just realized that this CL breaks ...

5 years, 9 months ago (2015-03-03 15:58:07 UTC) #4

danrubel

Committed patchset #3 (id:40001) manually as 44174 (presubmit successful).

5 years, 9 months ago (2015-03-03 15:59:03 UTC) #5

danrubel

5 years, 9 months ago (2015-03-03 16:40:00 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/972933002/diff/40001/pkg/analysis_server/test...
File pkg/analysis_server/test/completion_test.dart (right):

https://codereview.chromium.org/972933002/diff/40001/pkg/analysis_server/test...
pkg/analysis_server/test/completion_test.dart:256: ], failingTests: '123');
On 2015/03/03 15:58:07, danrubel wrote:
> Just realized that this CL breaks new <prefix>.
> Will address this in the next CL.

https://codereview.chromium.org/972193002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages