add arguments to constructor completions

pkg/analysis_server/test/services/completion/imported_computer_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.toplevel;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 82 matching lines @@
     DartCompletionCache cache = request.cache;
     if (isCached(cache.importedTypeSuggestions, completion) ||
         isCached(cache.importedVoidReturnSuggestions, completion) ||
         isCached(cache.libraryPrefixSuggestions, completion) ||
         isCached(cache.otherImportedSuggestions, completion)) {
       fail('expected $completion NOT to be cached');
     }
   }
 
   @override
+  CompletionSuggestion assertSuggestImportedConstructor(String name) {
+    return assertSuggestConstructor(name);
+  }
+
+  @override
   CompletionSuggestion assertSuggestImportedField(String name, String type,
       {int relevance: DART_RELEVANCE_INHERITED_FIELD}) {
     return assertSuggestField(name, type, relevance: relevance);
   }
 
   CompletionSuggestion assertSuggestImportedGetter(
       String name, String returnType,
       {int relevance: DART_RELEVANCE_INHERITED_ACCESSOR}) {
     return assertSuggestGetter(name, returnType, relevance: relevance);
   }
@@ skipping 227 matching lines @@
       expect(suggestion.parameterNames, hasLength(2));
       expect(suggestion.parameterNames[0], 'x');
       expect(suggestion.parameterTypes[0], 'dynamic');
       expect(suggestion.parameterNames[1], 'y');
       expect(suggestion.parameterTypes[1], 'int');
       expect(suggestion.requiredParameterCount, 2);
       expect(suggestion.hasNamedParameters, false);
     });
   }
 
+  test_InstanceCreationExpression() {
+    addSource('/testA.dart', '''
+class A {foo(){var f; {var x;}}}
+class B {B(this.x, [String boo]) { } int x;}
+class C {C.bar({boo: 'hoo', int z: 0}) { } }''');
+    addTestSource('''
+import "/testA.dart";
+main() {new ^ String x = "hello";}''');
+    computeFast();
+    return computeFull((bool result) {
+      CompletionSuggestion suggestion;
+
+      suggestion = assertSuggestImportedConstructor('Object');
+      expect(suggestion.element.parameters, '()');
+      expect(suggestion.parameterNames, hasLength(0));
+      expect(suggestion.requiredParameterCount, 0);
+      expect(suggestion.hasNamedParameters, false);
+
+      suggestion = assertSuggestImportedConstructor('A');
+      expect(suggestion.element.parameters, '()');
+      expect(suggestion.parameterNames, hasLength(0));
+      expect(suggestion.requiredParameterCount, 0);
+      expect(suggestion.hasNamedParameters, false);
+
+      suggestion = assertSuggestImportedConstructor('B');
+      expect(suggestion.element.parameters, '(int x, [String boo])');
+      expect(suggestion.parameterNames, hasLength(2));
+      expect(suggestion.parameterNames[0], 'x');
+      expect(suggestion.parameterTypes[0], 'int');
+      expect(suggestion.parameterNames[1], 'boo');
+      expect(suggestion.parameterTypes[1], 'String');
+      expect(suggestion.requiredParameterCount, 1);
+      expect(suggestion.hasNamedParameters, false);
+
+      suggestion = assertSuggestImportedConstructor('C.bar');
+      expect(
+          suggestion.element.parameters, "({dynamic boo: 'hoo'}, {int z: 0})");
+      expect(suggestion.parameterNames, hasLength(2));
+      expect(suggestion.parameterNames[0], 'boo');
+      expect(suggestion.parameterTypes[0], 'dynamic');
+      expect(suggestion.parameterNames[1], 'z');
+      expect(suggestion.parameterTypes[1], 'int');
+      expect(suggestion.requiredParameterCount, 0);
+      expect(suggestion.hasNamedParameters, true);
+    });
+  }
+
   test_method_parameters_mixed_required_and_named() {
     addSource('/libA.dart', '''
 class A {
   void m(x, {int y}) {}
 }
 ''');
     addTestSource('''
 import '/libA.dart';
 class B extends A {
   main() {^}
@@ skipping 270 matching lines @@
   }
 
   @override
   test_partFile_TypeName2() {
     return super.test_partFile_TypeName2().then((_) {
       expect(request.cache.importKey,
           'library libA;import "/testB.dart";part "/testA.dart";');
     });
   }
 }