Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: pkg/analysis_server/lib/src/services/completion/optype.dart

Issue 972933002: add arguments to constructor completions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/optype.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/optype.dart b/pkg/analysis_server/lib/src/services/completion/optype.dart
index ba7892cd0c4d3a1498da018665cab02e74dc9eba..197ffbaaf48a55eb05b88582ce249dbff56c0076 100644
--- a/pkg/analysis_server/lib/src/services/completion/optype.dart
+++ b/pkg/analysis_server/lib/src/services/completion/optype.dart
@@ -16,6 +16,11 @@ import 'package:analyzer/src/generated/scanner.dart';
class OpType {
/**
+ * Indicates whether constructor suggestions should be included.
+ */
+ bool includeConstructorSuggestions = false;
+
+ /**
* Indicates whether invocation suggestions should be included.
*/
bool includeInvocationSuggestions = false;
@@ -346,7 +351,7 @@ class _OpTypeAstVisitor extends GeneralizingAstVisitor {
@override
void visitInstanceCreationExpression(InstanceCreationExpression node) {
if (identical(entity, node.constructorName)) {
- optype.includeTypeNameSuggestions = true;
+ optype.includeConstructorSuggestions = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698