Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 96643003: Change Future.timeout callback to a named parameter. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove dartium change, reduce safetyMargin for VM to 0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M sdk/lib/io/timer_impl.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/lib/async/multiple_timer_test.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests/lib/async/stream_periodic3_test.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests/lib/async/timer_isolate_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-11-29 14:58:36 UTC) #1
floitsch
LGTM.
7 years ago (2013-11-29 15:04:19 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r30790 (presubmit successful).
7 years ago (2013-12-02 08:48:09 UTC) #3
Lasse Reichstein Nielsen
7 years ago (2013-12-09 12:06:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698