tests/lib/async/timer_isolate_test.dart - Issue 96643003: Change Future.timeout callback to a named parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/async/timer_isolate_test.dart

Issue 96643003: Change Future.timeout callback to a named parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove dartium change, reduce safetyMargin for VM to 0. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/async/timer_isolate_test.dart

diff --git a/tests/lib/async/timer_isolate_test.dart b/tests/lib/async/timer_isolate_test.dart

index 8c6c5fbf7165654b36853f311e6a35f8a7f6dada..1e0cb9bf4d2dd476faef0b0a764ad393738fcbe9 100644

--- a/tests/lib/async/timer_isolate_test.dart

+++ b/tests/lib/async/timer_isolate_test.dart

@@ -13,7 +13,7 @@ const Duration TIMEOUT = const Duration(milliseconds: 100);

// Some browsers (Firefox and IE so far) can trigger too early. Add a safety

// margin. We use identical(1, 1.0) as an easy way to know if the test is

// compiled by dart2js.

-int get safetyMargin => identical(1, 1.0) ? 100 : 1;

+int get safetyMargin => identical(1, 1.0) ? 100 : 0;

createTimer(replyTo) {

new Timer(TIMEOUT, () {

« no previous file with comments | « tests/lib/async/stream_periodic3_test.dart ('k') | tests/lib/async/timer_test.dart » ('j') | no next file with comments »