Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tests/lib/async/multiple_timer_test.dart

Issue 96643003: Change Future.timeout callback to a named parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove dartium change, reduce safetyMargin for VM to 0. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/timer_impl.dart ('k') | tests/lib/async/stream_periodic3_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/multiple_timer_test.dart
diff --git a/tests/lib/async/multiple_timer_test.dart b/tests/lib/async/multiple_timer_test.dart
index 0a57ef012b6b496c46cc3de82f24bde4a84fef7c..63108132f41743320923a57617bab21f769e220b 100644
--- a/tests/lib/async/multiple_timer_test.dart
+++ b/tests/lib/async/multiple_timer_test.dart
@@ -12,13 +12,11 @@ const Duration TIMEOUT2 = const Duration(seconds: 2);
const Duration TIMEOUT3 = const Duration(milliseconds: 500);
const Duration TIMEOUT4 = const Duration(milliseconds: 1500);
-// The stopwatch is more precise than the Timer. It can happen that
-// the TIMEOUT triggers *slightly* too early on the VM. So we add a millisecond
-// as safetymargin.
+// The stopwatch is more precise than the Timer.
// Some browsers (Firefox and IE so far) can trigger too early. So we add more
// margin. We use identical(1, 1.0) as an easy way to know if the test is
// compiled by dart2js.
-int get safetyMargin => identical(1, 1.0) ? 100 : 1;
+int get safetyMargin => identical(1, 1.0) ? 100 : 0;
main() {
test("multiple timer test", () {
« no previous file with comments | « sdk/lib/io/timer_impl.dart ('k') | tests/lib/async/stream_periodic3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698