Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 957343002: Make use of __proto__ when available. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make use of __proto__ when available. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44454

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -74 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 11 chunks +68 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart View 1 13 chunks +35 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_names.dart View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
herhut
This also contains some other fixes to make v8 optimize processClassData.
5 years, 10 months ago (2015-02-26 15:17:37 UTC) #1
herhut
5 years, 9 months ago (2015-02-27 08:46:52 UTC) #3
herhut
PING? This is a patch between some others that already have LGTM and blocks those...
5 years, 9 months ago (2015-03-09 13:15:19 UTC) #4
floitsch
https://codereview.chromium.org/957343002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart (right): https://codereview.chromium.org/957343002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart#newcode67 pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:67: } else if (firstChar === 43) { // 43 ...
5 years, 9 months ago (2015-03-09 15:37:09 UTC) #5
floitsch
and LGTM.
5 years, 9 months ago (2015-03-09 15:37:28 UTC) #6
herhut
https://codereview.chromium.org/957343002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart (right): https://codereview.chromium.org/957343002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart#newcode67 pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:67: } else if (firstChar === 43) { // 43 ...
5 years, 9 months ago (2015-03-10 12:53:55 UTC) #7
herhut
5 years, 9 months ago (2015-03-13 10:22:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698