Make use of __proto__ when available.

pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 // TODO(ahe): Share these with js_helper.dart.
 const FUNCTION_INDEX = 0;
 const NAME_INDEX = 1;
 const CALL_NAME_INDEX = 2;
@@ skipping 37 matching lines @@
       emitter.generateEmbeddedGlobalAccess(embeddedNames.MANGLED_GLOBAL_NAMES);
   jsAst.Expression mangledNamesAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.MANGLED_NAMES);
   jsAst.Expression librariesAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.LIBRARIES);
   jsAst.Expression metadataAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.METADATA);
 
   jsAst.Statement processClassData = js.statement('''{
   function processClassData(cls, descriptor, processedClasses) {
-    var newDesc = map(); // Use a slow object.
+    descriptor = convertToSlowObject(descriptor); // Use a slow object.
     var previousProperty;
     var properties = Object.keys(descriptor);
     for (var i = 0; i < properties.length; i++) {
       var property = properties[i];
-      var firstChar = property.substring(0, 1);
+      var firstChar = property.charCodeAt(0);
       if (property === "static") {
-        processStatics(#embeddedStatics[cls] = descriptor[property],
+        processStatics(#embeddedStatics[cls] = descriptor.static,
                        processedClasses);
-      } else if (firstChar === "+") {
+      } else if (firstChar === 43) { // 43 is aka "+".

[floitsch, 2015/03/09 15:37:09]

"is aka" -> "is" or "aka", although that doesn't seem to come from this CL.

[herhut, 2015/03/10 12:53:54]

Done.

         mangledNames[previousProperty] = property.substring(1);
         var flag = descriptor[property];
         if (flag > 0)
           descriptor[previousProperty].$reflectableField = flag;
-      } else if (firstChar === "*") {
-        newDesc[previousProperty].$defaultValuesField = descriptor[property];
-        var optionalMethods = newDesc.$methodsWithOptionalArgumentsField;
+      } else if (firstChar === 42) { // 42 is aka "*"
+        descriptor[previousProperty].$defaultValuesField = descriptor[property];
+        var optionalMethods = descriptor.$methodsWithOptionalArgumentsField;
         if (!optionalMethods) {
-          newDesc.$methodsWithOptionalArgumentsField = optionalMethods={}
+          descriptor.$methodsWithOptionalArgumentsField = optionalMethods={}
         }
         optionalMethods[property] = previousProperty;
       } else {
         var elem = descriptor[property];
         if (property !== "${namer.classDescriptorProperty}" &&
             elem != null &&
             elem.constructor === Array &&
             property !== "<>") {
-          addStubs(newDesc, elem, property, false, []);
+          addStubs(descriptor, elem, property, false, []);
         } else {
-          newDesc[previousProperty = property] = elem;
+          previousProperty = property;
         }
       }
     }
 
     /* The 'fields' are either a constructor function or a
      * string encoding fields, constructor and superclass. Gets the
      * superclass and fields in the format
      *   'Super;field1,field2'
      * from the CLASS_DESCRIPTOR_PROPERTY property on the descriptor.
      */
-    var classData = newDesc["${namer.classDescriptorProperty}"],
+    var classData = descriptor["${namer.classDescriptorProperty}"],
         split, supr, fields = classData;
 
     if (#hasRetainedMetadata)
       if (typeof classData == "object" &&
           classData instanceof Array) {
         classData = fields = classData[0];
       }
     // ${ClassBuilder.fieldEncodingDescription}.
     var s = fields.split(";");
     fields = s[1] == "" ? [] : s[1].split(",");
     supr = s[0];
     // ${ClassBuilder.functionTypeEncodingDescription}.
     split = supr.split(":");
     if (split.length == 2) {
       supr = split[0];
       var functionSignature = split[1];
       if (functionSignature)
-        newDesc.${namer.operatorSignature} = function(s) {
+        descriptor.${namer.operatorSignature} = function(s) {
           return function() {
             return #metadata[s];
           };
         }(functionSignature);
     }
 
     if (supr) processedClasses.pending[cls] = supr;
     if (#notInCspMode) {
       processedClasses.combinedConstructorFunction += defineClass(cls, fields);
       processedClasses.constructorsList.push(cls);
     }
-    processedClasses.collected[cls] = [globalObject, newDesc];
+    processedClasses.collected[cls] = [globalObject, descriptor];
     classes.push(cls);
   }
 }''', {'embeddedStatics': staticsAccess,
        'hasRetainedMetadata': backend.hasRetainedMetadata,
        'metadata': metadataAccess,
        'notInCspMode': !compiler.useContentSecurityPolicy});
 
   // TODO(zarah): Remove empty else branches in output when if(#hole) is false.
   jsAst.Statement processStatics = js.statement('''
     function processStatics(descriptor, processedClasses) {
       var properties = Object.keys(descriptor);
       for (var i = 0; i < properties.length; i++) {
         var property = properties[i];
         if (property === "${namer.classDescriptorProperty}") continue;
         var element = descriptor[property];
-        var firstChar = property.substring(0, 1);
+        var firstChar = property.charCodeAt(0);
         var previousProperty;
-        if (firstChar === "+") {
+        if (firstChar === 43) { // 43 is aka "+".
           mangledGlobalNames[previousProperty] = property.substring(1);
           var flag = descriptor[property];
           if (flag > 0)
             descriptor[previousProperty].$reflectableField = flag;
           if (element && element.length)
             #typeInformation[previousProperty] = element;
-        } else if (firstChar === "*") {
+        } else if (firstChar === 42) { // 42 is aka "*"
           globalObject[previousProperty].$defaultValuesField = element;
           var optionalMethods = descriptor.$methodsWithOptionalArgumentsField;
           if (!optionalMethods) {
             descriptor.$methodsWithOptionalArgumentsField = optionalMethods = {}
           }
           optionalMethods[property] = previousProperty;
         } else if (typeof element === "function") {
           globalObject[previousProperty = property] = element;
           functions.push(property);
           #globalFunctions[property] = element;
@@ skipping 318 matching lines @@
 (function() {
   var result = $array[$index];
   if ($check) {
     throw new Error(
         name + ": expected value of type \'$type\' at index " + ($index) +
         " but got " + (typeof result));
   }
   return result;
 })()''';
 }