Make use of __proto__ when available.

pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 // TODO(ahe): Share these with js_helper.dart.
 const FUNCTION_INDEX = 0;
 const NAME_INDEX = 1;
 const CALL_NAME_INDEX = 2;
@@ skipping 37 matching lines @@
       emitter.generateEmbeddedGlobalAccess(embeddedNames.MANGLED_GLOBAL_NAMES);
   jsAst.Expression mangledNamesAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.MANGLED_NAMES);
   jsAst.Expression librariesAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.LIBRARIES);
   jsAst.Expression metadataAccess =
       emitter.generateEmbeddedGlobalAccess(embeddedNames.METADATA);
 
   jsAst.Statement processClassData = js.statement('''{
   function processClassData(cls, descriptor, processedClasses) {
-    var newDesc = {};
+    descriptor = convertToSlowObject(descriptor); // Use a slow object.
     var previousProperty;
-    for (var property in descriptor) {
-      if (!hasOwnProperty.call(descriptor, property)) continue;
-      var firstChar = property.substring(0, 1);
+    var properties = Object.keys(descriptor);
+    for (var i = 0; i < properties.length; i++) {
+      var property = properties[i];
+      var firstChar = property.charCodeAt(0);
       if (property === "static") {
-        processStatics(#embeddedStatics[cls] = descriptor[property], 
+        processStatics(#embeddedStatics[cls] = descriptor.static,
                        processedClasses);
-      } else if (firstChar === "+") {
+      } else if (firstChar === 43) { // 43 is "+".
         mangledNames[previousProperty] = property.substring(1);
         var flag = descriptor[property];
         if (flag > 0)
           descriptor[previousProperty].$reflectableField = flag;
-      } else if (firstChar === "*") {
-        newDesc[previousProperty].$defaultValuesField = descriptor[property];
-        var optionalMethods = newDesc.$methodsWithOptionalArgumentsField;
+      } else if (firstChar === 42) { // 42 is "*"
+        descriptor[previousProperty].$defaultValuesField = descriptor[property];
+        var optionalMethods = descriptor.$methodsWithOptionalArgumentsField;
         if (!optionalMethods) {
-          newDesc.$methodsWithOptionalArgumentsField = optionalMethods={}
+          descriptor.$methodsWithOptionalArgumentsField = optionalMethods={}
         }
         optionalMethods[property] = previousProperty;
       } else {
         var elem = descriptor[property];
         if (property !== "${namer.classDescriptorProperty}" &&
             elem != null &&
             elem.constructor === Array &&
             property !== "<>") {
-          addStubs(newDesc, elem, property, false, descriptor, []);
+          addStubs(descriptor, elem, property, false, []);
         } else {
-          newDesc[previousProperty = property] = elem;
+          previousProperty = property;
         }
       }
     }
 
     /* The 'fields' are either a constructor function or a
      * string encoding fields, constructor and superclass. Gets the
      * superclass and fields in the format
      *   'Super;field1,field2'
      * from the CLASS_DESCRIPTOR_PROPERTY property on the descriptor.
      */
-    var classData = newDesc["${namer.classDescriptorProperty}"],
+    var classData = descriptor["${namer.classDescriptorProperty}"],
         split, supr, fields = classData;
 
     if (#hasRetainedMetadata)
       if (typeof classData == "object" &&
           classData instanceof Array) {
         classData = fields = classData[0];
       }
     // ${ClassBuilder.fieldEncodingDescription}.
     var s = fields.split(";");
     fields = s[1] == "" ? [] : s[1].split(",");
     supr = s[0];
     // ${ClassBuilder.functionTypeEncodingDescription}.
     split = supr.split(":");
     if (split.length == 2) {
       supr = split[0];
       var functionSignature = split[1];
       if (functionSignature)
-        newDesc.${namer.operatorSignature} = function(s) {
+        descriptor.${namer.operatorSignature} = function(s) {
           return function() {
             return #metadata[s];
           };
         }(functionSignature);
     }
 
     if (supr) processedClasses.pending[cls] = supr;
     if (#notInCspMode) {
       processedClasses.combinedConstructorFunction += defineClass(cls, fields);
       processedClasses.constructorsList.push(cls);
     }
-    processedClasses.collected[cls] = [globalObject, newDesc];
+    processedClasses.collected[cls] = [globalObject, descriptor];
     classes.push(cls);
   }
 }''', {'embeddedStatics': staticsAccess,
        'hasRetainedMetadata': backend.hasRetainedMetadata,
        'metadata': metadataAccess,
        'notInCspMode': !compiler.useContentSecurityPolicy});
 
   // TODO(zarah): Remove empty else branches in output when if(#hole) is false.
   jsAst.Statement processStatics = js.statement('''
     function processStatics(descriptor, processedClasses) {
-      for (var property in descriptor) {
-        if (!hasOwnProperty.call(descriptor, property)) continue;
+      var properties = Object.keys(descriptor);
+      for (var i = 0; i < properties.length; i++) {
+        var property = properties[i];
         if (property === "${namer.classDescriptorProperty}") continue;
         var element = descriptor[property];
-        var firstChar = property.substring(0, 1);
+        var firstChar = property.charCodeAt(0);
         var previousProperty;
-        if (firstChar === "+") {
+        if (firstChar === 43) { // 43 is "+".
           mangledGlobalNames[previousProperty] = property.substring(1);
           var flag = descriptor[property];
           if (flag > 0)
             descriptor[previousProperty].$reflectableField = flag;
           if (element && element.length)
             #typeInformation[previousProperty] = element;
-        } else if (firstChar === "*") {
+        } else if (firstChar === 42) { // 42 is "*"
           globalObject[previousProperty].$defaultValuesField = element;
           var optionalMethods = descriptor.$methodsWithOptionalArgumentsField;
           if (!optionalMethods) {
             descriptor.$methodsWithOptionalArgumentsField = optionalMethods = {}
           }
           optionalMethods[property] = previousProperty;
         } else if (typeof element === "function") {
           globalObject[previousProperty = property] = element;
           functions.push(property);
           #globalFunctions[property] = element;
         } else if (element.constructor === Array) {
           if (#needsStructuredMemberInfo) {
-            addStubs(globalObject, element, property,
-                     true, descriptor, functions);
+            addStubs(globalObject, element, property, true, functions);
           }
         } else {
           // We will not enter this case if no classes are defined.
           if (#hasClasses) {
             previousProperty = property;
             processClassData(property, element, processedClasses);
           }
         }
       }
     }
 ''', {'typeInformation': typeInformationAccess,
       'globalFunctions': globalFunctionsAccess,
       'hasClasses': oldEmitter.needsClassSupport,
       'needsStructuredMemberInfo': oldEmitter.needsStructuredMemberInfo});
 
 
   /**
    * See [dart2js.js_emitter.ContainerBuilder.addMemberMethod] for format of
    * [array].
    */
   jsAst.Statement addStubs = js.statement('''
-  function addStubs(descriptor, array, name, isStatic,
-                    originalDescriptor, functions) {
+  function addStubs(descriptor, array, name, isStatic, functions) {
     var index = $FUNCTION_INDEX, alias = array[index], f;
     if (typeof alias == "string") {
       f = array[++index];
     } else {
       f = alias;
       alias = name;
     }
-    var funcs = [originalDescriptor[name] = descriptor[name] =
-        descriptor[alias] = f];
+    var funcs = [descriptor[name] = descriptor[alias] = f];
     f.\$stubName = name;
     functions.push(name);
     for (; index < array.length; index += 2) {
       f = array[index + 1];
       if (typeof f != "function") break;
       f.\$stubName = ${readString("array", "index + 2")};
       funcs.push(f);
       if (f.\$stubName) {
-        originalDescriptor[f.\$stubName] = descriptor[f.\$stubName] = f;
+        descriptor[f.\$stubName] = f;
         functions.push(f.\$stubName);
       }
     }
+    index++;
     for (var i = 0; i < funcs.length; index++, i++) {
-      funcs[i].\$callName = ${readString("array", "index + 1")};
+      funcs[i].\$callName = ${readString("array", "index")};
     }
-    var getterStubName = ${readString("array", "++index")};
+    var getterStubName = ${readString("array", "index")};
     array = array.slice(++index);
     var requiredParameterInfo = ${readInt("array", "0")};
     var requiredParameterCount = requiredParameterInfo >> 1;
     var isAccessor = (requiredParameterInfo & 1) === 1;
     var isSetter = requiredParameterInfo === 3;
     var isGetter = requiredParameterInfo === 1;
     var optionalParameterInfo = ${readInt("array", "1")};
     var optionalParameterCount = optionalParameterInfo >> 1;
     var optionalParametersAreNamed = (optionalParameterInfo & 1) === 1;
     var isIntercepted =
            requiredParameterCount + optionalParameterCount != funcs[0].length;
     var functionTypeIndex = ${readFunctionType("array", "2")};
     var unmangledNameIndex = $unmangledNameIndex;
 
     if (getterStubName) {
       f = tearOff(funcs, array, isStatic, name, isIntercepted);
       descriptor[name].\$getter = f;
       f.\$getterStub = true;
       // Used to create an isolate using spawnFunction.
       if (isStatic) #globalFunctions[name] = f;
-      originalDescriptor[getterStubName] = descriptor[getterStubName] = f;
+      descriptor[getterStubName] = f;
       funcs.push(f);
       if (getterStubName) functions.push(getterStubName);
       f.\$stubName = getterStubName;
       f.\$callName = null;
       // Update the interceptedNames map (which only exists if `invokeOn` was
       // enabled).
       if (#enabledInvokeOn)
         if (isIntercepted) #interceptedNames[getterStubName] = 1;
     }
 
@@ skipping 45 matching lines @@
   if (!#statics) #statics = map();
   if (!#typeInformation) #typeInformation = map(); 
   if (!#globalFunctions) #globalFunctions = map();
   if (#enabledInvokeOn)
     if (!#interceptedNames) #interceptedNames = #interceptedNamesSet;
   var libraries = #libraries;
   var mangledNames = #mangledNames;
   var mangledGlobalNames = #mangledGlobalNames;
   var hasOwnProperty = Object.prototype.hasOwnProperty;
   var length = reflectionData.length;
-  var processedClasses = Object.create(null);
-  processedClasses.collected = Object.create(null);
-  processedClasses.pending = Object.create(null);
+  var processedClasses = map();
+  processedClasses.collected = map();
+  processedClasses.pending = map();
   if (#notInCspMode) {
     processedClasses.constructorsList = [];
     // For every class processed [processedClasses.combinedConstructorFunction]
     // will be updated with the corresponding constructor function. 
     processedClasses.combinedConstructorFunction =
         "function \$reflectable(fn){fn.$reflectableField=1;return fn};\\n"+
         "var \$desc;\\n";
   }
   for (var i = 0; i < length; i++) {
     var data = reflectionData[i];
@@ skipping 87 matching lines @@
         constructor["${namer.metadataField}"] = desc;
       allClasses[cls] = constructor;
       globalObject[cls] = constructor;
     }
     constructors = null;
 
     #finishClassFunction;
 
     #trivialNsmHandlers;
 
-    for (var cls in processedClasses.pending) finishClass(cls);
+    var properties = Object.keys(processedClasses.pending);
+    for (var i = 0; i < properties.length; i++) finishClass(properties[i]);
   }
 }''', {'allClasses': allClassesAccess,
        'debugFastObjects': DEBUG_FAST_OBJECTS,
        'isTreeShakingDisabled': backend.isTreeShakingDisabled,
        'finishClassFunction': oldEmitter.buildFinishClass(hasNativeClasses),
        'trivialNsmHandlers': oldEmitter.buildTrivialNsmHandlers(),
        'inCspMode': compiler.useContentSecurityPolicy,
        'notInCspMode': !compiler.useContentSecurityPolicy});
 
   List<jsAst.Statement> incrementalSupport = <jsAst.Statement>[];
@@ skipping 60 matching lines @@
 (function() {
   var result = $array[$index];
   if ($check) {
     throw new Error(
         name + ": expected value of type \'$type\' at index " + ($index) +
         " but got " + (typeof result));
   }
   return result;
 })()''';
 }