Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 952333002: Don't do folder existence checks when parsing pub list results. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 9 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't do folder existence checks when parsing pub list results. It's just a waste of time since we already to folder existence checks when resolving package URI's. Besides, all the folders output by pub list should always exist except in pathological situations. Improves total analysis time by about 2%. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=44137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -7 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 5 chunks +17 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 2 chunks +23 lines, -1 line 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-25 22:00:55 UTC) #2
danrubel
lgtm
5 years, 10 months ago (2015-02-25 23:52:26 UTC) #3
Paul Berry
5 years, 9 months ago (2015-03-02 18:29:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698