Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analyzer/test/source/package_map_provider_test.dart

Issue 952333002: Don't do folder existence checks when parsing pub list results. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/file_system/physical_resource_provider_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/source/package_map_provider_test.dart
diff --git a/pkg/analyzer/test/source/package_map_provider_test.dart b/pkg/analyzer/test/source/package_map_provider_test.dart
index 311a5f57c19a3f2add68caa911e43b00e8476c02..d2d890badb70c7d75577f291f5a72bda14141fc0 100644
--- a/pkg/analyzer/test/source/package_map_provider_test.dart
+++ b/pkg/analyzer/test/source/package_map_provider_test.dart
@@ -52,7 +52,7 @@ main() {
expect(result[packageName][0].path, equals(folderPath));
});
- test('ignore nonexistent folder', () {
+ test("don't ignore nonexistent folder", () {
String packageName = 'foo';
String folderPath = '/path/to/folder';
Map<String, List<Folder>> result = parsePackageMap({
@@ -60,7 +60,11 @@ main() {
packageName: folderPath
}
}).packageMap;
- expect(result, hasLength(0));
+ expect(result, hasLength(1));
+ expect(result.keys, contains(packageName));
+ expect(result[packageName], hasLength(1));
+ expect(result[packageName][0], new isInstanceOf<Folder>());
+ expect(result[packageName][0].path, equals(folderPath));
});
test('package maps to list', () {
« no previous file with comments | « pkg/analyzer/test/file_system/physical_resource_provider_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698