pkg/analyzer/lib/source/pub_package_map_provider.dart - Issue 952333002: Don't do folder existence checks when parsing pub list results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/source/pub_package_map_provider.dart

Issue 952333002: Don't do folder existence checks when parsing pub list results. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer/lib/file_system/physical_file_system.dart ('k') | pkg/analyzer/test/file_system/memory_file_system_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/source/pub_package_map_provider.dart

diff --git a/pkg/analyzer/lib/source/pub_package_map_provider.dart b/pkg/analyzer/lib/source/pub_package_map_provider.dart

index a45fc9065dbbb92bef5c220bf511f8a3bf29642e..8a8a6656ae36a3ad4f1eeb6533937235be9a2fb3 100644

--- a/pkg/analyzer/lib/source/pub_package_map_provider.dart

+++ b/pkg/analyzer/lib/source/pub_package_map_provider.dart

@@ -95,7 +95,7 @@ class PubPackageMapProvider implements PackageMapProvider {

List<Folder> folders = <Folder>[];

for (var path in paths) {

if (path is String) {

- Resource resource = folder.getChild(path);

+ Resource resource = folder.getChildAssumingFolder(path);

if (resource is Folder) {

folders.add(resource);

}