Issue 946023003: Fix for searching constructor references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 946023003: Fix for searching constructor references. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for searching constructor references. Currently we record constructor declarations and SearchEngine returns them as "references". But it is not quite a reference, and it is used only as a way to get name range. With this change to ConstructorElement we don't need to have these artificial references. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43932

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -92 lines)			Patch
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart	View	4 chunks	+20 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/search/search_engine_internal.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/search/element_references_test.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	pkg/analysis_server/test/services/search/search_engine_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	14 chunks	+68 lines, -38 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element_handle.dart	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 10 months ago (2015-02-20 22:10:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43932 (presubmit successful).

Expand Messages | Collapse Messages