Fix for searching constructor references.

pkg/analysis_server/test/search/element_references_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.search.element_references;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/index/index.dart';
@@ skipping 42 matching lines @@
 class A {
   A.named(p);
 }
 main() {
   new A.named(1);
   new A.named(2);
 }
 ''');
     await findElementReferences('named(p)', false);
     expect(searchElement.kind, ElementKind.CONSTRUCTOR);
+    expect(results, hasLength(2));
     assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);
     assertHasResult(SearchResultKind.REFERENCE, '.named(2)', 6);
   }
 
   test_constructor_named_potential() async {
     // Constructors in other classes shouldn't be considered potential matches,
     // nor should unresolved method calls, since constructor call sites are
     // statically bound to their targets).
     addTestFile('''
 class A {
   A.named(p); // A
 }
 class B {
   B.named(p);
 }
 f(x) {
   new A.named(1);
   new B.named(2);
   x.named(3);
 }
 ''');
     await findElementReferences('named(p); // A', true);
     expect(searchElement.kind, ElementKind.CONSTRUCTOR);
-    assertHasResult(SearchResultKind.DECLARATION, '.named(p)', 6);
+    expect(results, hasLength(1));
     assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);
-    expect(results, hasLength(2));
   }
 
   test_constructor_unnamed() async {
     addTestFile('''
 class A {
   A(p);
 }
 main() {
   new A(1);
   new A(2);
 }
 ''');
     await findElementReferences('A(p)', false);
     expect(searchElement.kind, ElementKind.CONSTRUCTOR);
+    expect(results, hasLength(2));
     assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);
     assertHasResult(SearchResultKind.REFERENCE, '(2)', 0);
   }
 
   test_constructor_unnamed_potential() async {
     // Constructors in other classes shouldn't be considered potential matches,
     // even if they are also unnamed (since constructor call sites are
     // statically bound to their targets).
     // Also, assignments to local variables shouldn't be considered potential
     // matches.
     addTestFile('''
 class A {
   A(p); // A
 }
 class B {
   B(p);
   foo() {
     int k;
     k = 3;
   }
 }
 main() {
   new A(1);
   new B(2);
 }
 ''');
     await findElementReferences('A(p)', true);
     expect(searchElement.kind, ElementKind.CONSTRUCTOR);
-    assertHasResult(SearchResultKind.DECLARATION, '(p); // A', 0);
+    expect(results, hasLength(1));
     assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);
-    expect(results, hasLength(2));
   }
 
   test_field_explicit() async {
     addTestFile('''
 class A {
   var fff; // declaration
   A(this.fff); // in constructor
   m() {
     fff = 2;
     fff += 3;
@@ skipping 578 matching lines @@
   print(vvv);
 }
 ''');
     Request request =
         new SearchFindElementReferencesParams(testFile, 0, false).toRequest('0');
     Response response = await waitResponse(request);
     expect(response.error, isNotNull);
     expect(response.error.code, RequestErrorCode.NO_INDEX_GENERATED);
   }
 }