pkg/analysis_server/test/search/element_references_test.dart - Issue 946023003: Fix for searching constructor references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/search/element_references_test.dart

Issue 946023003: Fix for searching constructor references. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/search/search_engine_internal.dart ('k') | pkg/analysis_server/test/services/index/dart_index_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/search/element_references_test.dart

diff --git a/pkg/analysis_server/test/search/element_references_test.dart b/pkg/analysis_server/test/search/element_references_test.dart

index aaadfb37a4b21492f92576824609110aa187ea13..538e1ee457bb61cf165ccd707cce5f61775a9453 100644

--- a/pkg/analysis_server/test/search/element_references_test.dart

+++ b/pkg/analysis_server/test/search/element_references_test.dart

@@ -60,6 +60,7 @@ main() {

''');

await findElementReferences('named(p)', false);

expect(searchElement.kind, ElementKind.CONSTRUCTOR);

+ expect(results, hasLength(2));

assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);

assertHasResult(SearchResultKind.REFERENCE, '.named(2)', 6);

}

@@ -83,9 +84,8 @@ f(x) {

''');

await findElementReferences('named(p); // A', true);

expect(searchElement.kind, ElementKind.CONSTRUCTOR);

- assertHasResult(SearchResultKind.DECLARATION, '.named(p)', 6);

+ expect(results, hasLength(1));

assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);

- expect(results, hasLength(2));

}

test_constructor_unnamed() async {

@@ -100,6 +100,7 @@ main() {

''');

await findElementReferences('A(p)', false);

expect(searchElement.kind, ElementKind.CONSTRUCTOR);

+ expect(results, hasLength(2));

assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);

assertHasResult(SearchResultKind.REFERENCE, '(2)', 0);

}

@@ -128,9 +129,8 @@ main() {

''');

await findElementReferences('A(p)', true);

expect(searchElement.kind, ElementKind.CONSTRUCTOR);

- assertHasResult(SearchResultKind.DECLARATION, '(p); // A', 0);

+ expect(results, hasLength(1));

assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);

- expect(results, hasLength(2));

}

test_field_explicit() async {