Issue 921833002: Issue 22381. Fix for navigating to constructor from redirecting factory constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921833002: Issue 22381. Fix for navigating to constructor from redirecting factory constructor. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Issue 22381. Fix for navigating to constructor from redirecting factory constructor. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22381 Committed: https://code.google.com/p/dart/source/detail?r=43731

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+199 lines, -45 lines)			Patch
M	pkg/analysis_server/lib/src/computer/computer_navigation.dart	View	3 chunks	+38 lines, -31 lines	1 comment	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_navigation_test.dart	View	2 chunks	+124 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	4 chunks	+30 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/921833002/diff/1/pkg/analysis_server/lib/src/computer/computer_navigation.dart File pkg/analysis_server/lib/src/computer/computer_navigation.dart (right): https://codereview.chromium.org/921833002/diff/1/pkg/analysis_server/lib/src/computer/computer_navigation.dart#newcode254 pkg/analysis_server/lib/src/computer/computer_navigation.dart:254: element = classElement; Why the temporary variable? Why ...

5 years, 10 months ago (2015-02-12 17:56:19 UTC) #2

scheglov

5 years, 10 months ago (2015-02-12 17:58:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43731 (presubmit successful).

Expand Messages | Collapse Messages