Issue 22381. Fix for navigating to constructor from redirecting factory constructor.

pkg/analysis_server/lib/src/computer/computer_navigation.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library computer.navigation;
 
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 132 matching lines @@
         computer._addRegion_nodeStart_nodeEnd(
             firstNode,
             lastNode,
             node.element);
       }
     }
     super.visitConstructorDeclaration(node);
   }
 
   @override
+  visitConstructorName(ConstructorName node) {
+    AstNode parent = node.parent;
+    if (parent is InstanceCreationExpression &&
+        parent.constructorName == node) {
+      _addConstructorName(parent, node);
+    } else if (parent is ConstructorDeclaration &&
+        parent.redirectedConstructor == node) {
+      _addConstructorName(node, node);
+    }
+  }
+
+  @override
   visitExportDirective(ExportDirective node) {
     ExportElement exportElement = node.element;
     if (exportElement != null) {
       Element element = exportElement.exportedLibrary;
       computer._addRegion_tokenStart_nodeEnd(node.keyword, node.uri, element);
     }
     super.visitExportDirective(node);
   }
 
   @override
   visitImportDirective(ImportDirective node) {
     ImportElement importElement = node.element;
     if (importElement != null) {
       Element element = importElement.importedLibrary;
       computer._addRegion_tokenStart_nodeEnd(node.keyword, node.uri, element);
     }
     super.visitImportDirective(node);
   }
 
   @override
   visitIndexExpression(IndexExpression node) {
     super.visitIndexExpression(node);
     computer._addRegionForToken(node.rightBracket, node.bestElement);
   }
 
   @override
-  visitInstanceCreationExpression(InstanceCreationExpression node) {
-    Element element = node.staticElement;
-    ConstructorName constructorName = node.constructorName;
-    if (element != null && constructorName != null) {
-      // if a synthetic constructor, navigate to the class
-      if (element.isSynthetic) {
-        ClassElement classElement = element.enclosingElement;
-        element = classElement;
-      }
-      // add regions
-      TypeName typeName = constructorName.type;
-      TypeArgumentList typeArguments = typeName.typeArguments;
-      if (typeArguments == null) {
-        computer._addRegion_nodeStart_nodeEnd(node, constructorName, element);
-      } else {
-        computer._addRegion_nodeStart_nodeEnd(node, typeName.name, element);
-        // <TypeA, TypeB>
-        typeArguments.accept(this);
-        // optional ".name"
-        if (constructorName.period != null) {
-          computer._addRegion_tokenStart_nodeEnd(
-              constructorName.period,
-              constructorName,
-              element);
-        }
-      }
-    }
-    _safelyVisit(node.argumentList);
-  }
-
-  @override
   visitPartDirective(PartDirective node) {
     computer._addRegion_tokenStart_nodeEnd(
         node.keyword,
         node.uri,
         node.element);
     super.visitPartDirective(node);
   }
 
   @override
   visitPartOfDirective(PartOfDirective node) {
@@ skipping 35 matching lines @@
     SimpleIdentifier name = node.constructorName;
     if (name != null) {
       computer._addRegion_nodeStart_nodeEnd(node, name, element);
     } else {
       computer._addRegionForToken(node.keyword, element);
     }
     // process arguments
     _safelyVisit(node.argumentList);
   }
 
+  void _addConstructorName(AstNode parent, ConstructorName node) {
+    Element element = node.staticElement;
+    if (element == null) {
+      return;
+    }
+    // if a synthetic constructor, navigate to the class
+    if (element.isSynthetic) {
+      ClassElement classElement = element.enclosingElement;
+      element = classElement;

[Brian Wilkerson, 2015/02/12 17:56:19]

Why the temporary variable? Why not just:
  element = element.enclosingElement;

+    }
+    // add regions
+    TypeName typeName = node.type;
+    TypeArgumentList typeArguments = typeName.typeArguments;
+    if (typeArguments == null) {
+      computer._addRegion_nodeStart_nodeEnd(parent, node, element);
+    } else {
+      computer._addRegion_nodeStart_nodeEnd(parent, typeName.name, element);
+      // <TypeA, TypeB>
+      typeArguments.accept(this);
+      // optional ".name"
+      if (node.period != null) {
+        computer._addRegion_tokenStart_nodeEnd(node.period, node, element);
+      }
+    }
+  }
+
   void _safelyVisit(AstNode node) {
     if (node != null) {
       node.accept(this);
     }
   }
 }