Issue 22381. Fix for navigating to constructor from redirecting factory constructor.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/collections.dart';
@@ skipping 382 matching lines @@
       server.sendResponse(
           new Response.serverError(_request, exception, stackTrace));
       _reset();
     });
   }
 
   /**
    * Initializes this context to perform a refactoring with the specified
    * parameters. The existing [Refactoring] is reused or created as needed.
    */
-  Future _init(RefactoringKind kind, String file,
-      int offset, int length) async {
+  Future _init(RefactoringKind kind, String file, int offset,
+      int length) async {
     await server.onAnalysisComplete;
     // check if we can continue with the existing Refactoring instance
     if (this.kind == kind &&
         this.file == file &&
         this.offset == offset &&
         this.length == length) {
       return;
     }
     _reset();
     this.kind = kind;
@@ skipping 66 matching lines @@
     }
     if (kind == RefactoringKind.RENAME) {
       List<AstNode> nodes = server.getNodesAtOffset(file, offset);
       List<Element> elements = server.getElementsOfNodes(nodes, offset);
       if (nodes.isNotEmpty && elements.isNotEmpty) {
         AstNode node = nodes[0];
         Element element = elements[0];
         if (element is FieldFormalParameterElement) {
           element = (element as FieldFormalParameterElement).field;
         }
-        // climb from "Class" in "new Class()" to "new Class()"
-        if (node.parent is TypeName &&
-            node.parent.parent is ConstructorName &&
-            node.parent.parent.parent is InstanceCreationExpression) {
-          InstanceCreationExpression creation = node.parent.parent.parent;
-          node = creation;
-          element = creation.staticElement;
+        // climb from "Class" in "new Class.named()" to "Class.named"
+        if (node.parent is TypeName && node.parent.parent is ConstructorName) {
+          ConstructorName constructor = node.parent.parent;
+          node = constructor;
+          element = constructor.staticElement;
         }
         // do create the refactoring
         refactoring = new RenameRefactoring(searchEngine, element);
         feedback =
             new RenameFeedback(node.offset, node.length, 'kind', 'oldName');
       }
     }
     if (refactoring == null) {
       initStatus =
           new RefactoringStatus.fatal('Unable to create a refactoring');
@@ skipping 107 matching lines @@
     }
     if (refactoring is RenameRefactoring) {
       RenameRefactoring renameRefactoring = refactoring;
       RenameOptions renameOptions = params.options;
       renameRefactoring.newName = renameOptions.newName;
       return renameRefactoring.checkNewName();
     }
     return new RefactoringStatus();
   }
 }