Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 913903002: Use async/await in refactorings. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -275 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 2 chunks +23 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 2 chunks +30 lines, -31 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 2 chunks +14 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 2 chunks +9 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 1 chunk +7 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 4 chunks +76 lines, -84 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 2 chunks +9 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 3 chunks +57 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-10 22:13:14 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-10 23:01:56 UTC) #2
scheglov
5 years, 10 months ago (2015-02-11 01:21:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698