Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/move_file.dart

Issue 913903002: Use async/await in refactorings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/move_file.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/move_file.dart b/pkg/analysis_server/lib/src/services/refactoring/move_file.dart
index b0e719726b668c7bd0773e74c9fd2e74f177e10d..0811b7551d40c4c7a701c506a1db285a86829900 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/move_file.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/move_file.dart
@@ -56,10 +56,10 @@ class MoveFileRefactoringImpl extends RefactoringImpl implements
}
@override
- Future<SourceChange> createChange() {
+ Future<SourceChange> createChange() async {
change = new SourceChange('Update File References');
List<Source> librarySources = context.getLibrariesContaining(source);
- return Future.forEach(librarySources, (Source librarySource) {
+ await Future.forEach(librarySources, (Source librarySource) async {
CompilationUnitElement unitElement =
context.getCompilationUnitElement(source, librarySource);
if (unitElement != null) {
@@ -73,17 +73,16 @@ class MoveFileRefactoringImpl extends RefactoringImpl implements
_updateUriReferences(library.parts);
}
// update reference to the unit
- return searchEngine.searchReferences(unitElement).then((matches) {
- List<SourceReference> references = getSourceReferences(matches);
- for (SourceReference reference in references) {
- String newUri = _computeNewUri(reference);
- reference.addEdit(change, "'$newUri'");
- }
- });
+ List<SearchMatch> matches =
+ await searchEngine.searchReferences(unitElement);
+ List<SourceReference> references = getSourceReferences(matches);
+ for (SourceReference reference in references) {
+ String newUri = _computeNewUri(reference);
+ reference.addEdit(change, "'$newUri'");
+ }
}
- }).then((_) {
- return change;
});
+ return change;
}
@override

Powered by Google App Engine
This is Rietveld 408576698