Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart

Issue 913903002: Use async/await in refactorings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
index bea040a01c10e67b757cdab73f080ece428dd557..c6ed68c2ee06649c43db54fb1247f6b51efa72be 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart
@@ -47,28 +47,28 @@ class ConvertGetterToMethodRefactoringImpl extends RefactoringImpl implements
}
@override
- Future<SourceChange> createChange() {
+ Future<SourceChange> createChange() async {
change = new SourceChange(refactoringName);
// function
if (element.enclosingElement is CompilationUnitElement) {
_updateElementDeclaration(element);
- return _updateElementReferences(element).then((_) => change);
+ await _updateElementReferences(element);
}
// method
if (element.enclosingElement is ClassElement) {
FieldElement field = element.variable;
- return getHierarchyMembers(searchEngine, field).then((elements) {
- return Future.forEach(elements, (FieldElement field) {
- PropertyAccessorElement getter = field.getter;
- if (!getter.isSynthetic) {
- _updateElementDeclaration(getter);
- return _updateElementReferences(getter);
- }
- });
- }).then((_) => change);
+ Set<ClassMemberElement> elements =
+ await getHierarchyMembers(searchEngine, field);
+ await Future.forEach(elements, (FieldElement field) {
+ PropertyAccessorElement getter = field.getter;
+ if (!getter.isSynthetic) {
+ _updateElementDeclaration(getter);
+ return _updateElementReferences(getter);
+ }
+ });
}
- // not reachable
- return null;
+ // done
+ return change;
}
@override
@@ -106,16 +106,15 @@ class ConvertGetterToMethodRefactoringImpl extends RefactoringImpl implements
}
}
- Future _updateElementReferences(Element element) {
- return searchEngine.searchReferences(element).then((matches) {
- List<SourceReference> references = getSourceReferences(matches);
- for (SourceReference reference in references) {
- Element refElement = reference.element;
- SourceRange refRange = reference.range;
- // insert "()"
- var edit = new SourceEdit(refRange.end, 0, "()");
- doSourceChange_addElementEdit(change, refElement, edit);
- }
- });
+ Future _updateElementReferences(Element element) async {
+ List<SearchMatch> matches = await searchEngine.searchReferences(element);
+ List<SourceReference> references = getSourceReferences(matches);
+ for (SourceReference reference in references) {
+ Element refElement = reference.element;
+ SourceRange refRange = reference.range;
+ // insert "()"
+ var edit = new SourceEdit(refRange.end, 0, "()");
+ doSourceChange_addElementEdit(change, refElement, edit);
+ }
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698