corelib: Don't blow up in memory if a duration receives a string as argument.

corelib: Don't blow up in memory if a duration receives a string as argument.

BUG= http://dartbug.com/22309
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43658

[floitsch, 2015-02-09 16:22:37]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-02-10 15:46:10]

lgtm

[sra1, 2015-02-10 16:02:30]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-02-10 16:02:31]

https://codereview.chromium.org/913503003/diff/1/tests/corelib/duration2_test...
File tests/corelib/duration2_test.dart (right):

https://codereview.chromium.org/913503003/diff/1/tests/corelib/duration2_test...
tests/corelib/duration2_test.dart:24: // No check for `microseconds` since it
doesn't throw in unchecked mode and
Add the check.  Surely it does throw -  0 + "str" should be an error.

milliseconds: "str" probably doesn't result in out-of-memory either with a 3k
string.

[floitsch, 2015-02-10 16:38:39]

New patchsets have been uploaded after l-g-t-m from lrn@google.com

[floitsch, 2015-02-10 16:39:17]

https://codereview.chromium.org/913503003/diff/1/tests/corelib/duration2_test...
File tests/corelib/duration2_test.dart (right):

https://codereview.chromium.org/913503003/diff/1/tests/corelib/duration2_test...
tests/corelib/duration2_test.dart:24: // No check for `microseconds` since it
doesn't throw in unchecked mode and
On 2015/02/10 16:02:30, sra1 wrote:
> Add the check.  Surely it does throw -  0 + "str" should be an error.
> 
> milliseconds: "str" probably doesn't result in out-of-memory either with a 3k
> string.

Done.

[floitsch, 2015-02-10 16:39:47]

Committed patchset #2 (id:20001) manually as 43658 (presubmit successful).