Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: tests/corelib/duration2_test.dart

Issue 913503003: corelib: Don't blow up in memory if a duration receives a string as argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test for microseconds. Increase size of string. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/duration.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/duration2_test.dart
diff --git a/tests/corelib/duration2_test.dart b/tests/corelib/duration2_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a1131171877eb4b8cd9ccf61a5a6c10f451ac338
--- /dev/null
+++ b/tests/corelib/duration2_test.dart
@@ -0,0 +1,29 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+main() {
+ // If the duration class multiplies "str" * microseconds-per-day (instead of
+ // (microseconds-per-day * "str") it will try to build up a huge string and
+ // terminate with an out-of-memory exception instead of an ArgumentError or
+ // TypeError.
+ // See dartbug.com/22309
+
+ String longString = "str" * 1000;
+ Expect.throws(() => new Duration(days: longString),
+ (e) => e is ArgumentError || e is TypeError);
+ Expect.throws(() => new Duration(hours: longString),
+ (e) => e is ArgumentError || e is TypeError);
+ Expect.throws(() => new Duration(minutes: longString),
+ (e) => e is ArgumentError || e is TypeError);
+ Expect.throws(() => new Duration(seconds: longString),
+ (e) => e is ArgumentError || e is TypeError);
+ Expect.throws(() => new Duration(milliseconds: longString),
+ (e) => e is ArgumentError || e is TypeError ||
+ e is NoSuchMethodError);
+ Expect.throws(() => new Duration(microseconds: longString),
+ (e) => e is ArgumentError || e is TypeError ||
+ e is NoSuchMethodError);
+}
« no previous file with comments | « sdk/lib/core/duration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698