Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: tests/corelib/duration2_test.dart

Issue 913503003: corelib: Don't blow up in memory if a duration receives a string as argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test for microseconds. Increase size of string. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/core/duration.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 import "package:expect/expect.dart";
6
7 main() {
8 // If the duration class multiplies "str" * microseconds-per-day (instead of
9 // (microseconds-per-day * "str") it will try to build up a huge string and
10 // terminate with an out-of-memory exception instead of an ArgumentError or
11 // TypeError.
12 // See dartbug.com/22309
13
14 String longString = "str" * 1000;
15 Expect.throws(() => new Duration(days: longString),
16 (e) => e is ArgumentError || e is TypeError);
17 Expect.throws(() => new Duration(hours: longString),
18 (e) => e is ArgumentError || e is TypeError);
19 Expect.throws(() => new Duration(minutes: longString),
20 (e) => e is ArgumentError || e is TypeError);
21 Expect.throws(() => new Duration(seconds: longString),
22 (e) => e is ArgumentError || e is TypeError);
23 Expect.throws(() => new Duration(milliseconds: longString),
24 (e) => e is ArgumentError || e is TypeError ||
25 e is NoSuchMethodError);
26 Expect.throws(() => new Duration(microseconds: longString),
27 (e) => e is ArgumentError || e is TypeError ||
28 e is NoSuchMethodError);
29 }
OLDNEW
« no previous file with comments | « sdk/lib/core/duration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698