Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 908463004: Convert refactoring tests to use 'await'. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert refactoring tests to use 'await'. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -777 lines) Patch
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 2 chunks +13 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 2 chunks +12 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 2 chunks +12 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 18 chunks +95 lines, -111 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 41 chunks +181 lines, -218 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 5 chunks +28 lines, -35 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 14 chunks +78 lines, -86 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 9 chunks +34 lines, -44 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 18 chunks +73 lines, -85 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 4 chunks +15 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 12 chunks +47 lines, -53 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 11 chunks +53 lines, -57 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-06 21:49:54 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-06 22:10:17 UTC) #2
scheglov
5 years, 10 months ago (2015-02-06 22:13:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698