Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart

Issue 908463004: Convert refactoring tests to use 'await'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart b/pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart
index 643079a062bab2983771d1e0e70caaf49b5d3759..4b9f82d877f11ec0141d34496d406b8b24320682 100644
--- a/pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart
@@ -7,6 +7,7 @@ library test.services.refactoring.convert_getter_to_method;
import 'dart:async';
import 'package:analysis_server/src/protocol.dart' hide ElementKind;
+import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:unittest/unittest.dart';
@@ -131,26 +132,23 @@ main() {
'Only explicit getters can be converted to methods.');
}
- Future _assertInitialConditions_fatal(String message) {
- return refactoring.checkInitialConditions().then((status) {
- assertRefactoringStatus(
- status,
- RefactoringProblemSeverity.FATAL,
- expectedMessage: message);
- });
+ Future _assertInitialConditions_fatal(String message) async {
+ RefactoringStatus status = await refactoring.checkInitialConditions();
+ assertRefactoringStatus(
+ status,
+ RefactoringProblemSeverity.FATAL,
+ expectedMessage: message);
}
/**
* Checks that all conditions are OK and the result of applying [refactoring]
* change to [testUnit] is [expectedCode].
*/
- Future _assertSuccessfulRefactoring(String expectedCode) {
- return assertRefactoringConditionsOK().then((_) {
- return refactoring.createChange().then((SourceChange refactoringChange) {
- this.refactoringChange = refactoringChange;
- assertTestChangeResult(expectedCode);
- });
- });
+ Future _assertSuccessfulRefactoring(String expectedCode) async {
+ await assertRefactoringConditionsOK();
+ SourceChange refactoringChange = await refactoring.createChange();
+ this.refactoringChange = refactoringChange;
+ assertTestChangeResult(expectedCode);
}
void _createRefactoring(String elementName) {

Powered by Google App Engine
This is Rietveld 408576698