Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

Issue 908463004: Convert refactoring tests to use 'await'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart
index 90b61537c9274c74ad678f321e05408d40c66a59..2d01a487c303d0426ced385e56e5b8c1bab62731 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart
@@ -5,6 +5,7 @@
library test.services.refactoring.rename_constructor;
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:unittest/unittest.dart';
@@ -21,7 +22,7 @@ main() {
@reflectiveTest
class RenameConstructorTest extends RenameRefactoringTest {
- test_checkFinalConditions_hasMember_constructor() {
+ test_checkFinalConditions_hasMember_constructor() async {
indexTestUnit('''
class A {
A.test() {}
@@ -31,16 +32,15 @@ class A {
_createConstructorDeclarationRefactoring('test() {}');
// check status
refactoring.newName = 'newName';
- return refactoring.checkFinalConditions().then((status) {
- assertRefactoringStatus(
- status,
- RefactoringProblemSeverity.ERROR,
- expectedMessage: "Class 'A' already declares constructor with name 'newName'.",
- expectedContextSearch: 'newName() {} // existing');
- });
+ RefactoringStatus status = await refactoring.checkFinalConditions();
+ assertRefactoringStatus(
+ status,
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Class 'A' already declares constructor with name 'newName'.",
+ expectedContextSearch: 'newName() {} // existing');
}
- test_checkFinalConditions_hasMember_method() {
+ test_checkFinalConditions_hasMember_method() async {
indexTestUnit('''
class A {
A.test() {}
@@ -50,13 +50,12 @@ class A {
_createConstructorDeclarationRefactoring('test() {}');
// check status
refactoring.newName = 'newName';
- return refactoring.checkFinalConditions().then((status) {
- assertRefactoringStatus(
- status,
- RefactoringProblemSeverity.ERROR,
- expectedMessage: "Class 'A' already declares method with name 'newName'.",
- expectedContextSearch: 'newName() {} // existing');
- });
+ RefactoringStatus status = await refactoring.checkFinalConditions();
+ assertRefactoringStatus(
+ status,
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Class 'A' already declares method with name 'newName'.",
+ expectedContextSearch: 'newName() {} // existing');
}
test_checkNewName() {

Powered by Google App Engine
This is Rietveld 408576698