Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891693003: Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer (Closed)

Created:
5 years, 10 months ago by jwren
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry, pquitslund
CC:
reviews_dartlang.org, pquitslund, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43489

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jwren
5 years, 10 months ago (2015-02-04 22:04:22 UTC) #2
Paul Berry
lgtm
5 years, 10 months ago (2015-02-04 22:06:18 UTC) #3
jwren
Committed patchset #2 (id:20001) manually as 43489 (presubmit successful).
5 years, 10 months ago (2015-02-04 22:07:02 UTC) #4
pquitslund
5 years, 10 months ago (2015-02-04 22:43:21 UTC) #6
Message was sent while issue was closed. 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698