Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 891693003: Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 98097b4a6f02ae86592f5802538683bc0ba87146..01d1855ca67ed51bb6c4e407f06b80662eb0ff6c 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -90,12 +90,18 @@ class AnalysisDomainHandler implements RequestHandler {
/// Implement the `analysis.getLibraryDependencies` request.
Response getLibraryDependencies(Request request) {
- LibraryDependencyCollector collector = new LibraryDependencyCollector(
- server.getAnalysisContexts());
- Set<String> libraries = collector.collectLibraryDependencies();
- Map<String, Map<String, List<String>>> packageMap = collector.calculatePackageMap(server.folderMap);
- return new AnalysisGetLibraryDependenciesResult(
- libraries.toList(growable: false), packageMap).toResponse(request.id);
+ server.onAnalysisComplete.then((_) {
+ LibraryDependencyCollector collector =
+ new LibraryDependencyCollector(server.getAnalysisContexts());
+ Set<String> libraries = collector.collectLibraryDependencies();
+ Map<String, Map<String, List<String>>> packageMap =
+ collector.calculatePackageMap(server.folderMap);
+ server.sendResponse(new AnalysisGetLibraryDependenciesResult(
+ libraries.toList(growable: false),
+ packageMap).toResponse(request.id));
+ });
+ // delay response
+ return Response.DELAYED_RESPONSE;
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698