Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 891693003: Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library domain.analysis; 5 library domain.analysis;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/analysis_server.dart'; 9 import 'package:analysis_server/src/analysis_server.dart';
10 import 'package:analysis_server/src/computer/computer_hover.dart'; 10 import 'package:analysis_server/src/computer/computer_hover.dart';
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 if (hoverInformation != null) { 83 if (hoverInformation != null) {
84 hovers.add(hoverInformation); 84 hovers.add(hoverInformation);
85 } 85 }
86 } 86 }
87 // send response 87 // send response
88 return new AnalysisGetHoverResult(hovers).toResponse(request.id); 88 return new AnalysisGetHoverResult(hovers).toResponse(request.id);
89 } 89 }
90 90
91 /// Implement the `analysis.getLibraryDependencies` request. 91 /// Implement the `analysis.getLibraryDependencies` request.
92 Response getLibraryDependencies(Request request) { 92 Response getLibraryDependencies(Request request) {
93 LibraryDependencyCollector collector = new LibraryDependencyCollector( 93 server.onAnalysisComplete.then((_) {
94 server.getAnalysisContexts()); 94 LibraryDependencyCollector collector =
95 Set<String> libraries = collector.collectLibraryDependencies(); 95 new LibraryDependencyCollector(server.getAnalysisContexts());
96 Map<String, Map<String, List<String>>> packageMap = collector.calculatePacka geMap(server.folderMap); 96 Set<String> libraries = collector.collectLibraryDependencies();
97 return new AnalysisGetLibraryDependenciesResult( 97 Map<String, Map<String, List<String>>> packageMap =
98 libraries.toList(growable: false), packageMap).toResponse(request.id); 98 collector.calculatePackageMap(server.folderMap);
99 server.sendResponse(new AnalysisGetLibraryDependenciesResult(
100 libraries.toList(growable: false),
101 packageMap).toResponse(request.id));
102 });
103 // delay response
104 return Response.DELAYED_RESPONSE;
99 } 105 }
100 106
101 @override 107 @override
102 Response handleRequest(Request request) { 108 Response handleRequest(Request request) {
103 try { 109 try {
104 String requestName = request.method; 110 String requestName = request.method;
105 if (requestName == ANALYSIS_GET_ERRORS) { 111 if (requestName == ANALYSIS_GET_ERRORS) {
106 return getErrors(request); 112 return getErrors(request);
107 } else if (requestName == ANALYSIS_GET_HOVER) { 113 } else if (requestName == ANALYSIS_GET_HOVER) {
108 return getHover(request); 114 return getHover(request);
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 201 }
196 if (newOptions.generateHints != null) { 202 if (newOptions.generateHints != null) {
197 updaters.add((engine.AnalysisOptionsImpl options) { 203 updaters.add((engine.AnalysisOptionsImpl options) {
198 options.hint = newOptions.generateHints; 204 options.hint = newOptions.generateHints;
199 }); 205 });
200 } 206 }
201 server.updateOptions(updaters); 207 server.updateOptions(updaters);
202 return new AnalysisUpdateOptionsResult().toResponse(request.id); 208 return new AnalysisUpdateOptionsResult().toResponse(request.id);
203 } 209 }
204 } 210 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698