Issue 885443012: Undo unnecessary changes to ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885443012: Undo unnecessary changes to ARM assembler. (Closed)

Created:
5 years, 10 months ago by Florian Schneider

Modified:
5 years, 10 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	runtime/vm/assembler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	5 chunks	+20 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

Addressing comments from https://codereview.chromium.org/886173003/

5 years, 10 months ago (2015-02-09 15:50:00 UTC) #1

Florian Schneider

5 years, 10 months ago (2015-02-09 16:14:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r43596 (presubmit successful).