Issue 873313003: Cleanup some ambiguous and incorrect types and disable a case that in analyzer.dart that seems like…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 873313003: Cleanup some ambiguous and incorrect types and disable a case that in analyzer.dart that seems like… (Closed)

Created:
5 years, 11 months ago by Jacob

Modified:
5 years, 10 months ago

Reviewers:
terry, kevmoo

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
git@github.com:dart-lang/csslib.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Cleanup some ambiguous and incorrect types and disable a case that in analyzer.dart that seems like it is broken. BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/csslib/commit/59a5e3fb60c144dd23b065e8f4772312fa4a7f7c

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -34 lines)			Patch
M	CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/parser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/analyzer.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/polyfill.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/property.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/src/tree.dart	View		8 chunks	+17 lines, -22 lines	0 comments	Download
M	lib/visitor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Jacob

5 years, 10 months ago (2015-02-02 21:45:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
59a5e3fb60c144dd23b065e8f4772312fa4a7f7c (presubmit successful).