Cleanup some ambiguous and incorrect types and disable a case that in analyzer.dart that seems like…

lib/src/property.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Representations of CSS styles. */
 
 part of csslib.parser;
 
 // TODO(terry): Prune down this file we do need some of the code in this file
 //              for darker, lighter, how to represent a Font, etc but alot of
@@ skipping 166 matching lines @@
     int g = Color.hexToInt(_argb.substring(nextIndex, nextIndex + 2));
     nextIndex += 2;
     int b = Color.hexToInt(_argb.substring(nextIndex, nextIndex + 2));
     return new Rgba(r, g, b, a);
   }
 
   Hsla get hsla => new Hsla.fromRgba(rgba);
 
   int get argbValue => Color.hexToInt(_argb);
 
-  bool operator ==(Object other) => Color.equal(this, other);
+  bool operator ==(other) => Color.equal(this, other);
 
   String toHexArgbString() => _argb;
 
   Color darker(num amount) {
     Rgba newRgba = Color._createNewTintShadeFromRgba(rgba, -amount);
     return new Color.hex("${newRgba.toHexArgbString()}");
   }
 
   Color lighter(num amount) {
     Rgba newRgba = Color._createNewTintShadeFromRgba(rgba, amount);
     return new Color.hex("${newRgba.toHexArgbString()}");
   }
 
-  static bool equal(ColorBase curr, Object other) {
+  static bool equal(ColorBase curr, other) {
     if (other is Color) {
       Color o = other;
       return o.toHexArgbString() == curr.toHexArgbString();
     } else if (other is Rgba) {
       Rgba rgb = other;
       return rgb.toHexArgbString() == curr.toHexArgbString();
     } else if (other is Hsla) {
       Hsla hsla = other;
       return hsla.toHexArgbString() == curr.toHexArgbString();
     } else {
@@ skipping 382 matching lines @@
       return v2;
     }
 
     if ((3 * vH) < 2) {
       return (v1 + (v2 - v1) * ((2 / 3 - vH) * 6));
     }
 
     return v1;
   }
 
-  bool operator ==(Object other) => Color.equal(this, other);
+  bool operator ==(other) => Color.equal(this, other);
 
   String get cssExpression {
     if (a == null) {
       return "#${Color.convertToHexString(r, g, b)}";
     } else {
       return "rgba($r,$g,$b,$a)";
     }
   }
 
   String toHexArgbString() => Color.convertToHexString(r, g, b, a);
@@ skipping 141 matching lines @@
   /**
    * Returns number as percentage 0..100.
    */
   num get lightnessPercentage => (_l * 100).round();
 
   /**
    * Returns number as 0..1
    */
   num get alpha => _a;
 
-  bool operator ==(Object other) => Color.equal(this, other);
+  bool operator ==(other) => Color.equal(this, other);
 
   String get cssExpression => (_a == null) ?
       "hsl($hueDegrees,$saturationPercentage,$lightnessPercentage)" :
       "hsla($hueDegrees,$saturationPercentage,$lightnessPercentage,$_a)";
 
   String toHexArgbString() => new Rgba.fromHsla(this).toHexArgbString();
 
   int get argbValue => Color.hexToInt(this.toHexArgbString());
 
   Color get color => new Color.createHsla(_h, _s, _l, _a);
@@ skipping 315 matching lines @@
     } else {
       return (size != null) ? size * 1.2 : null;
     }
   }
 
   int get hashCode {
     // TODO(jimhug): Lot's of potential collisions here. List of fonts, etc.
     return size.toInt() % family[0].hashCode;
   }
 
-  bool operator ==(Object other) {
+  bool operator ==(other) {
     if (other is! Font) return false;
     Font o = other;
     return o.size == size && o.family == family && o.weight == weight &&
         o.lineHeight == lineHeight && o.style == style && o.variant == variant;
   }
 
   // TODO(terry): This is fragile should probably just iterate through the list
   //              of fonts construction the font-family string.
   /** Return fonts as a comma seperated list sans the square brackets. */
   String get _fontsAsString {
@@ skipping 101 matching lines @@
   num get width => (left != null ? left : 0) + (right != null ? right : 0);
 
   /**
    * The total size of the vertical edges. Equal to [top] + [bottom], where
    * null is interpreted as 0px.
    */
   num get height => (top != null ? top : 0) + (bottom != null ? bottom : 0);
 }
 
 _mergeVal(x, y) => y != null ? y : x;