Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: lib/src/property.dart

Issue 873313003: Cleanup some ambiguous and incorrect types and disable a case that in analyzer.dart that seems like… (Closed) Base URL: git@github.com:dart-lang/csslib.git@master
Patch Set: ptal Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/polyfill.dart ('k') | lib/src/tree.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/property.dart
diff --git a/lib/src/property.dart b/lib/src/property.dart
index 777288a67bf2fa2e4404911eb5039fc02e8c5663..5219c2570d9c2ac7280e8cbb72af3a2e1cdb1cb8 100644
--- a/lib/src/property.dart
+++ b/lib/src/property.dart
@@ -184,7 +184,7 @@ class Color implements _StyleProperty, ColorBase {
int get argbValue => Color.hexToInt(_argb);
- bool operator ==(Object other) => Color.equal(this, other);
+ bool operator ==(other) => Color.equal(this, other);
String toHexArgbString() => _argb;
@@ -198,7 +198,7 @@ class Color implements _StyleProperty, ColorBase {
return new Color.hex("${newRgba.toHexArgbString()}");
}
- static bool equal(ColorBase curr, Object other) {
+ static bool equal(ColorBase curr, other) {
if (other is Color) {
Color o = other;
return o.toHexArgbString() == curr.toHexArgbString();
@@ -601,7 +601,7 @@ class Rgba implements _StyleProperty, ColorBase {
return v1;
}
- bool operator ==(Object other) => Color.equal(this, other);
+ bool operator ==(other) => Color.equal(this, other);
String get cssExpression {
if (a == null) {
@@ -763,7 +763,7 @@ class Hsla implements _StyleProperty, ColorBase {
*/
num get alpha => _a;
- bool operator ==(Object other) => Color.equal(this, other);
+ bool operator ==(other) => Color.equal(this, other);
String get cssExpression => (_a == null) ?
"hsl($hueDegrees,$saturationPercentage,$lightnessPercentage)" :
@@ -1099,7 +1099,7 @@ class Font implements _StyleProperty {
return size.toInt() % family[0].hashCode;
}
- bool operator ==(Object other) {
+ bool operator ==(other) {
if (other is! Font) return false;
Font o = other;
return o.size == size && o.family == family && o.weight == weight &&
« no previous file with comments | « lib/src/polyfill.dart ('k') | lib/src/tree.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698