Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869093003: dart2js: Rename metadataEmitter to metadataCollector and make it independent of old emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Rename metadataEmitter to metadataCollector and make it independent of old emitter. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43293

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Rename variable. #

Patch Set 4 : Fix bad rename and long line. #

Patch Set 5 : Fix more long lines. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -51 lines) Patch
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 1 chunk +1 line, -1 line 2 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 2 5 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_emitter.dart View 1 6 chunks +30 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_generator.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 10 months ago (2015-01-29 15:20:59 UTC) #2
herhut
lgtm https://codereview.chromium.org/869093003/diff/80001/pkg/compiler/lib/src/inferrer/node_tracer.dart File pkg/compiler/lib/src/inferrer/node_tracer.dart (right): https://codereview.chromium.org/869093003/diff/80001/pkg/compiler/lib/src/inferrer/node_tracer.dart#newcode78 pkg/compiler/lib/src/inferrer/node_tracer.dart:78: TracerVisitor(this.tracedType, TypeGraphInferrerEngine inferrer) Nice, I wonder how you ...
5 years, 10 months ago (2015-01-29 16:03:47 UTC) #3
floitsch
https://codereview.chromium.org/869093003/diff/80001/pkg/compiler/lib/src/inferrer/node_tracer.dart File pkg/compiler/lib/src/inferrer/node_tracer.dart (right): https://codereview.chromium.org/869093003/diff/80001/pkg/compiler/lib/src/inferrer/node_tracer.dart#newcode78 pkg/compiler/lib/src/inferrer/node_tracer.dart:78: TracerVisitor(this.tracedType, TypeGraphInferrerEngine inferrer) On 2015/01/29 16:03:47, herhut wrote: > ...
5 years, 10 months ago (2015-01-29 16:04:52 UTC) #4
floitsch
5 years, 10 months ago (2015-01-29 16:06:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 43293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698