Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/compiler/lib/src/js_backend/type_variable_handler.dart

Issue 869093003: dart2js: Rename metadataEmitter to metadataCollector and make it independent of old emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix more long lines. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/type_variable_handler.dart
diff --git a/pkg/compiler/lib/src/js_backend/type_variable_handler.dart b/pkg/compiler/lib/src/js_backend/type_variable_handler.dart
index e2d0f42d6280a1a5a6f6393af660125e0aefb50b..18d7f6776dfbc9c77be2e5dc543563897a6fe07b 100644
--- a/pkg/compiler/lib/src/js_backend/type_variable_handler.dart
+++ b/pkg/compiler/lib/src/js_backend/type_variable_handler.dart
@@ -36,7 +36,7 @@ class TypeVariableHandler {
ClassElement get typeVariableClass => backend.typeVariableClass;
CodeEmitterTask get task => backend.emitter;
- MetadataEmitter get emitter => task.metadataEmitter;
+ MetadataCollector get metadataCollector => task.metadataCollector;
Compiler get compiler => backend.compiler;
void registerClassWithTypeVariables(ClassElement cls) {
@@ -78,7 +78,7 @@ class TypeVariableHandler {
new DartString.literal(currentTypeVariable.name)));
ConstantExpression bound = new PrimitiveConstantExpression(
backend.constantSystem.createInt(
- emitter.reifyType(typeVariableElement.bound)));
+ metadataCollector.reifyType(typeVariableElement.bound)));
ConstantExpression type = backend.constants.createTypeConstant(cls);
List<AstConstant> arguments =
[wrapConstant(type), wrapConstant(name), wrapConstant(bound)];
@@ -129,7 +129,7 @@ class TypeVariableHandler {
}
/**
- * Adds [c] to [emitter.globalMetadata] and returns the index pointing to
+ * Adds [c] to [emitter.metadataCollector] and returns the index pointing to
* the entry.
*
* If the corresponding type variable has already been encountered an
@@ -142,16 +142,16 @@ class TypeVariableHandler {
int index;
if (typeVariableConstants.containsKey(variable)) {
index = typeVariableConstants[variable];
- emitter.globalMetadata[index] = name;
+ metadataCollector.globalMetadata[index] = name;
} else {
- index = emitter.addGlobalMetadata(name);
+ index = metadataCollector.addGlobalMetadata(name);
typeVariableConstants[variable] = index;
}
return index;
}
/**
- * Returns the index pointing to the constant in [emitter.globalMetadata]
+ * Returns the index pointing to the constant in [emitter.metadataCollector]
* representing this type variable.
*
* If the constant has not yet been constructed, an entry is allocated in
@@ -166,8 +166,9 @@ class TypeVariableHandler {
}
// TODO(15613): Remove quotes.
- emitter.globalMetadata.add('"Placeholder for ${variable}"');
- return typeVariableConstants[variable] = emitter.globalMetadata.length - 1;
+ metadataCollector.globalMetadata.add('"Placeholder for ${variable}"');
+ return typeVariableConstants[variable] =
+ metadataCollector.globalMetadata.length - 1;
}
List<int> typeVariablesOf(ClassElement classElement) {

Powered by Google App Engine
This is Rietveld 408576698