dart2js: Rename metadataEmitter to metadataCollector and make it independent of old emitter.

pkg/compiler/lib/src/inferrer/node_tracer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of type_graph_inferrer;
 
 // A set of selectors we know do not escape the elements inside the
 // list.
 Set<String> doesNotEscapeListSet = new Set<String>.from(
   const <String>[
@@ skipping 57 matching lines @@
 
 abstract class TracerVisitor<T extends TypeInformation>
     implements TypeInformationVisitor {
   final T tracedType;
   final TypeGraphInferrerEngine inferrer;
   final Compiler compiler;
 
   static const int MAX_ANALYSIS_COUNT = 16;
   final Setlet<Element> analyzedElements = new Setlet<Element>();
 
-  TracerVisitor(this.tracedType, inferrer)
+  TracerVisitor(this.tracedType, TypeGraphInferrerEngine inferrer)

[herhut, 2015/01/29 16:03:47]

Nice, I wonder how you stumbled across this one...

[floitsch, 2015/01/29 16:04:51]

The editor renamed the inferrer.compiler field when I did a rename from
"compiler" to "_compiler" on a completely unrelated class...

       : this.inferrer = inferrer, this.compiler = inferrer.compiler;
 
   // Work list that gets populated with [TypeInformation] that could
   // contain the container.
   final List<TypeInformation> workList = <TypeInformation>[];
 
   // Work list of lists to analyze after analyzing the users of a
   // [TypeInformation]. We know the [tracedType] has been stored in these
   // lists and we must check how it escapes from these lists.
   final List<ListTypeInformation> listsToAnalyze =
@@ skipping 297 matching lines @@
     }
     if (isParameterOfListAddingMethod(info.element) ||
         isParameterOfMapAddingMethod(info.element)) {
       // These elements are being handled in
       // [visitDynamicCallSiteTypeInformation].
       return;
     }
     addNewEscapeInformation(info);
   }
 }