add optional request field to record time at which client made request

add optional request field to record time at which client made request

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43113

[danrubel, 2015-01-23 02:28:56]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-01-23 14:57:20]

https://codereview.chromium.org/865383002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
(right):

https://codereview.chromium.org/865383002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java:792:
if (includeRequestTime) {
Is there any reason to make this optional?

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:184: // Verify that bad value is
ignored
We should not ignore an invalid value. The field is optional, so clients can
omit it if they don't want to report it, but if they report it and it's wrong we
should let them know.

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:72: since epoch).
We should explain what the value is used for in order to motivate clients to
provide the value.

[danrubel, 2015-01-23 16:00:43]

Addressed comments and uploaded changes. PTAL.

https://codereview.chromium.org/865383002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
(right):

https://codereview.chromium.org/865383002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java:792:
if (includeRequestTime) {
On 2015/01/23 14:57:20, Brian Wilkerson wrote:
> Is there any reason to make this optional?

Yes. It is easier for some tests to verify raw JSON when this is turned off.

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:184: // Verify that bad value is
ignored
On 2015/01/23 14:57:20, Brian Wilkerson wrote:
> We should not ignore an invalid value. The field is optional, so clients can
> omit it if they don't want to report it, but if they report it and it's wrong
we
> should let them know.

Good point. Done.

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/865383002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:72: since epoch).
On 2015/01/23 14:57:20, Brian Wilkerson wrote:
> We should explain what the value is used for in order to motivate clients to
> provide the value.

Good point. Done.

[Brian Wilkerson, 2015-01-23 16:13:22]

LGTM

[danrubel, 2015-01-23 17:41:34]

Committed patchset #3 (id:40001) manually as 43113 (presubmit successful).

[jwren, 2015-01-23 20:11:57]

On 2015/01/23 17:41:34, danrubel wrote:
> Committed patchset #3 (id:40001) manually as 43113 (presubmit successful).

LGTM