add optional request field to record time at which client made request

pkg/analysis_server/test/protocol_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.protocol;
 
 import 'dart:convert';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 131 matching lines @@
 
 
 @reflectiveTest
 class RequestTest {
   void test_fromJson() {
     Request original = new Request('one', 'aMethod');
     String json = JSON.encode(original.toJson());
     Request request = new Request.fromString(json);
     expect(request.id, equals('one'));
     expect(request.method, equals('aMethod'));
+    expect(request.clientRequestTime, isNull);
   }
 
   void test_fromJson_invalidId() {
     String json =
         '{"id":{"one":"two"},"method":"aMethod","params":{"foo":"bar"}}';
     Request request = new Request.fromString(json);
     expect(request, isNull);
   }
 
   void test_fromJson_invalidMethod() {
     String json =
         '{"id":"one","method":{"boo":"aMethod"},"params":{"foo":"bar"}}';
     Request request = new Request.fromString(json);
     expect(request, isNull);
   }
 
   void test_fromJson_invalidParams() {
     String json = '{"id":"one","method":"aMethod","params":"foobar"}';
     Request request = new Request.fromString(json);
     expect(request, isNull);
   }
 
+  void test_fromJson_withBadClientTime() {
+    Request original = new Request('one', 'aMethod', null, 347);
+    Map<String, Object> map = original.toJson();
+    // Insert bad value - should be int but client sent string instead
+    map[Request.CLIENT_REQUEST_TIME] = '347';
+    String json = JSON.encode(map);
+    Request request = new Request.fromString(json);
+    expect(request.id, equals('one'));
+    expect(request.method, equals('aMethod'));
+    // Verify that bad value is ignored

[Brian Wilkerson, 2015/01/23 14:57:20]

We should not ignore an invalid value. The field is optional, so clients can
omit it if they don't want to report it, but if they report it and it's wrong we
should let them know.

[danrubel, 2015/01/23 16:00:43]

Good point. Done.

+    expect(request.clientRequestTime, isNull);
+  }
+
+  void test_fromJson_withClientTime() {
+    Request original = new Request('one', 'aMethod', null, 347);
+    String json = JSON.encode(original.toJson());
+    Request request = new Request.fromString(json);
+    expect(request.id, equals('one'));
+    expect(request.method, equals('aMethod'));
+    expect(request.clientRequestTime, 347);
+  }
+
   void test_fromJson_withParams() {
     Request original = new Request('one', 'aMethod', {
       'foo': 'bar'
     });
     String json = JSON.encode(original.toJson());
     Request request = new Request.fromString(json);
     expect(request.id, equals('one'));
     expect(request.method, equals('aMethod'));
     expect(request.toJson()['params'], equals({
       'foo': 'bar'
@@ skipping 32 matching lines @@
     expect(response.toJson(), equals({
       Response.ID: '',
       Response.ERROR: {
         'code': 'INVALID_REQUEST',
         'message': 'Invalid request'
       }
     }));
   }
 
   void test_create_unanalyzedPriorityFiles() {
-    Response response =
-        new Response.unanalyzedPriorityFiles('0', 'file list');
+    Response response = new Response.unanalyzedPriorityFiles('0', 'file list');
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
         'code': 'UNANALYZED_PRIORITY_FILES',
         'message': "Unanalyzed files cannot be a priority: 'file list'"
       }
     }));
   }
@@ skipping 31 matching lines @@
     Response original = new Response('myId', result: {
       'foo': 'bar'
     });
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
     Map<String, Object> result = response.toJson()['result'];
     expect(result.length, equals(1));
     expect(result['foo'], equals('bar'));
   }
 }