Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 865383002: add optional request field to record time at which client made request (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/protocol_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index ad1421d1c16e74f501a686a957584289c4a8dff7..556c3406103985b32b073edb8dfa21637ed977d9 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -58,15 +58,20 @@
longer to process than others.
</p>
<p>
- Every request is required to have two fields and may have an
- optional third field. The first required field is the ‘id’
+ Every request is required to have two fields and may have two
+ additional optional fields. The first required field is the ‘id’
field, which is only used by the server to associate a response
with the request that generated the response. The second
required field is the ‘method’ field, which is used to determine
- what the server is being requested to do. The optional field is
+ what the server is being requested to do. One optional field is
the ‘params’ field, whose structure is dependent on the method
being requested. The structure of this field is described with
- each request for which it is required.
+ each request for which it is required. The other optional field
+ is the 'clientRequestTime' field, which is a number indicating
+ the time at which the client made the request (milliseconds
+ since epoch). Providing clientRequestTime helps us track
+ how responsive analysis server is to client requests
+ and better address any issues that occur.
</p>
<p>
Every response has up to three fields. The first field is the
« no previous file with comments | « pkg/analysis_server/test/protocol_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698