Handle super-method invocations in CPS->JS backend.

Handle super-method invocations in CPS->JS backend.

InvokeSuperMethod has been replaced by InvokeMethodDirectly. This
instruction works like InvokeMethod, except it has an explicit target
element that it always invokes, regardless of overriding.

The new instruction is easier to handle in the JS backend, it is more
amenable to inlining, and it should also be useful for calling
backend-specific methods, such as constructor bodies.

When targeting Dart, we translate it back to a 'super' at the end,
because the instruction is never used for any other purpose with
that backend.

R=karlklose@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43011

[asgerf, 2015-01-20 09:43:02]

asgerf@google.com changed reviewers:
+ karlklose@google.com, sigurdm@google.com

[sigurdm, 2015-01-20 10:54:25]

lgtm

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:785: // super
receiver.
Perhaps put asserts here that the invariant is maintained

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:172:
registry.registerStaticInvocation(target);
This should still be declaration.

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:218:
registry.registerDirectInvocation(node.target);
Register the declaration

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:76: if
(_glue.isInterceptedSelector(node.selector)) {
A space after open parenthesis

[asgerf, 2015-01-20 13:07:50]

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:785: // super
receiver.
On 2015/01/20 10:54:25, sigurdm wrote:
> Perhaps put asserts here that the invariant is maintained

Unfortunately there is no good way to do that. If the receiver is a variable, we
can't tell if it is initialized to 'this', and I don't want the validity of code
generation to be dependent on optimization.

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:172:
registry.registerStaticInvocation(target);
On 2015/01/20 10:54:25, sigurdm wrote:
> This should still be declaration.

Done.

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:218:
registry.registerDirectInvocation(node.target);
On 2015/01/20 10:54:25, sigurdm wrote:
> Register the declaration

Done.

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right):

https://codereview.chromium.org/861713002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:76: if
(_glue.isInterceptedSelector(node.selector)) {
On 2015/01/20 10:54:25, sigurdm wrote:
> A space after open parenthesis

That's _glue. There is no space.

[karlklose, 2015-01-20 14:25:42]

LGTM.

[asgerf, 2015-01-20 14:33:37]

Committed patchset #3 (id:40001) manually as 43011 (presubmit successful).