Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

Issue 861713002: Handle super-method invocations in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
index a142ecca5572c2fa366e233ec61b99da2607b3bd..0c504b75ee41f8910058b3452ccd535187ce0d05 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart
@@ -746,7 +746,7 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
assert(selector.kind == SelectorKind.GETTER ||
selector.kind == SelectorKind.INDEX);
if (isSuperCall(node)) {
- result = irBuilder.buildSuperInvocation(selector, arguments);
+ result = irBuilder.buildSuperInvocation(element, selector, arguments);
} else {
result =
irBuilder.buildDynamicInvocation(receiver, selector, arguments);
@@ -847,11 +847,12 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
return visitGetterSend(node);
} else {
Selector selector = elements.getSelector(node);
+ Element target = elements[node];
List<ir.Primitive> arguments = new List<ir.Primitive>();
for (ast.Node n in node.arguments) {
arguments.add(visit(n));
}
- return irBuilder.buildSuperInvocation(selector, arguments);
+ return irBuilder.buildSuperInvocation(target, selector, arguments);
}
}
@@ -954,13 +955,13 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
selector.kind == SelectorKind.INDEX);
if (selector.isIndexSet) {
if (isSuperCall(node)) {
- irBuilder.buildSuperIndexSet(index, valueToStore);
+ irBuilder.buildSuperIndexSet(element, index, valueToStore);
} else {
irBuilder.buildDynamicIndexSet(receiver, index, valueToStore);
}
} else {
if (isSuperCall(node)) {
- irBuilder.buildSuperSet(selector, valueToStore);
+ irBuilder.buildSuperSet(element, selector, valueToStore);
} else {
irBuilder.buildDynamicSet(receiver, selector, valueToStore);
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698