Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 861713002: Handle super-method invocations in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index 4aaacef222f0d783fac20ba811662315463165f5..fa63f24b67a26a8f692b83d280a8b31c58194dfb 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -159,15 +159,19 @@ class InvokeMethod extends Expression implements Invoke {
}
}
-class InvokeSuperMethod extends Expression implements Invoke {
+/// Invoke [target] on [receiver], bypassing ordinary dispatch semantics.
+class InvokeMethodDirectly extends Expression implements Invoke {
+ Expression receiver;
+ final Element target;
final Selector selector;
final List<Expression> arguments;
- InvokeSuperMethod(this.selector, this.arguments);
+ InvokeMethodDirectly(this.receiver, this.target, this.selector,
+ this.arguments);
- accept(ExpressionVisitor visitor) => visitor.visitInvokeSuperMethod(this);
+ accept(ExpressionVisitor visitor) => visitor.visitInvokeMethodDirectly(this);
accept1(ExpressionVisitor1 visitor, arg) {
- return visitor.visitInvokeSuperMethod(this, arg);
+ return visitor.visitInvokeMethodDirectly(this, arg);
}
}
@@ -697,7 +701,7 @@ abstract class ExpressionVisitor<E> {
E visitVariable(Variable node);
E visitInvokeStatic(InvokeStatic node);
E visitInvokeMethod(InvokeMethod node);
- E visitInvokeSuperMethod(InvokeSuperMethod node);
+ E visitInvokeMethodDirectly(InvokeMethodDirectly node);
E visitInvokeConstructor(InvokeConstructor node);
E visitConcatenateStrings(ConcatenateStrings node);
E visitConstant(Constant node);
@@ -722,7 +726,7 @@ abstract class ExpressionVisitor1<E, A> {
E visitVariable(Variable node, A arg);
E visitInvokeStatic(InvokeStatic node, A arg);
E visitInvokeMethod(InvokeMethod node, A arg);
- E visitInvokeSuperMethod(InvokeSuperMethod node, A arg);
+ E visitInvokeMethodDirectly(InvokeMethodDirectly node, A arg);
E visitInvokeConstructor(InvokeConstructor node, A arg);
E visitConcatenateStrings(ConcatenateStrings node, A arg);
E visitConstant(Constant node, A arg);
@@ -800,7 +804,8 @@ class RecursiveVisitor extends Visitor {
node.arguments.forEach(visitExpression);
}
- visitInvokeSuperMethod(InvokeSuperMethod node) {
+ visitInvokeMethodDirectly(InvokeMethodDirectly node) {
+ visitExpression(node.receiver);
node.arguments.forEach(visitExpression);
}
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698