Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 794933004: Remove tracking of factories used with type arguments. (Closed)

Created:
5 years, 11 months ago by karlklose
Modified:
5 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove tracking of factories used with type arguments. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42899

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update test expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 11 months ago (2015-01-13 14:22:01 UTC) #1
floitsch
LGTM. I committed the failing test, so you will have to update the status file.
5 years, 11 months ago (2015-01-13 17:21:08 UTC) #2
karlklose
5 years, 11 months ago (2015-01-15 08:39:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698