Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 794933004: Remove tracking of factories used with type arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update test expectation. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/registry.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index fe451e2d6796db789e657fda3c5368cc61d8fa25..f2ac807661c3f5a88f53516ba7ca35637624a88d 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -4305,11 +4305,6 @@ class SsaBuilder extends ResolvedVisitor {
send.arguments,
constructor.implementation));
- if (constructor.isFactoryConstructor &&
- !expectedType.typeArguments.isEmpty) {
- registry.registerFactoryWithTypeArguments();
- }
-
TypeMask elementType = computeType(constructor);
if (isFixedListConstructorCall) {
if (!inputs[0].isNumber(compiler)) {
@@ -5418,10 +5413,6 @@ class SsaBuilder extends ResolvedVisitor {
functionElement.computeEffectiveTargetType(type);
expectedType = localsHandler.substInContext(expectedType);
- if (constructor.isFactoryConstructor) {
- registry.registerFactoryWithTypeArguments();
- }
-
ClassElement cls = constructor.enclosingClass;
if (backend.classNeedsRti(cls)) {
« no previous file with comments | « pkg/compiler/lib/src/resolution/registry.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698