Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 794933004: Remove tracking of factories used with type arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update test expectation. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/runtime_types.dart
diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart
index bf008f11a7d9822349b3e6c2df3b2edf9e20ad7f..971758737f8a3eecc917e6ce7305bebbfee64b91 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart
@@ -60,7 +60,10 @@ class RuntimeTypes {
checkedBounds.add(bound);
}
- bool usingFactoryWithTypeArguments = false;
+ // TODO(21969): remove this and analyze instantiated types and factory calls
+ // instead to find out which types are instantiated, if finitely many, or if
+ // we have to use the more imprecise generic algorithm.
+ bool get cannotDetermineInstantiatedTypesPrecisely => true;
/**
* Compute type arguments of classes that use one of their type variables in
@@ -77,7 +80,7 @@ class RuntimeTypes {
// nothing to do.
if (classesUsingChecks.isEmpty) return;
Set<DartType> instantiatedTypes = universe.instantiatedTypes;
- if (universe.usingFactoryWithTypeArguments) {
+ if (cannotDetermineInstantiatedTypesPrecisely) {
for (DartType type in instantiatedTypes) {
if (type.kind != TypeKind.INTERFACE) continue;
InterfaceType interface = type;
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698